[ovs-dev] [PATCH] datapath: stt: Fix device list management.

Jesse Gross jesse at kernel.org
Sun Dec 20 23:22:02 UTC 2015


On Sun, Dec 20, 2015 at 5:48 PM, Pravin Shelar <pshelar at nicira.com> wrote:
> On Sun, Dec 20, 2015 at 10:31 AM, Jesse Gross <jesse at kernel.org> wrote:
>> One other thing that I noticed is that the STT fragment hash table
>> commingles fragments that were addressed to different destination
>> ports. This is unlikely to matter with the current implementation but
>> I'm not sure that it is right.
>
> STT fragment hash table has ack_seq which should be unique across
> different stt-dst-ports. So I am not sure if we need to check dst_port
> in the fragment lookup.

Yes, I think that it is fine with the current implementation on the
transmit side. However, I guess that assuming this on the receive side
is probably not the "right" thing to do.



More information about the dev mailing list