[ovs-dev] [PATCH] ofp-util: return BAD TYPE for consistency at ofputil_decode_group_mod()
Ben Pfaff
blp at ovn.org
Wed Dec 23 00:49:05 UTC 2015
On Tue, Dec 22, 2015 at 03:02:31PM -0200, Flavio Leitner wrote:
> Code earlier in this function validated that gm->type is valid, so
> the default case at the end of the function would be impossible, but
> since the code can change or perhaps get copied, return the correct
> error to keep consistency and avoid reintroducing the bug fixed by
> commit 09d4b951636b ("ofp-util: Reject bad group type and command
> with error instead of abort.")
>
> Signed-off-by: Flavio Leitner <fbl at redhat.com>
Thanks, applied to master.
More information about the dev
mailing list