[ovs-dev] [PATCH 4/5] ofp-actions: Add padding in ofpacts_pull_openflow_instructions()

Ben Pfaff blp at ovn.org
Wed Dec 23 07:12:23 UTC 2015


On Thu, Dec 10, 2015 at 05:58:15PM -0800, William Tu wrote:
> ofpacts_pull_openflow_instructions() should fill 'ofpacts' with a list
> of OpenFlow actions and each action (including the last one) should be
> padded to OFP_ACTION_ALIGN(8) bytes.
> 
> In most of the cases this is taken care of (e.g. by ofpacts_decode), but
> for the Goto-Table instruction (and Clear-Actions, based on a quick code
> inspection), this wasn't the case.
> 
> This caused the copy operation in recirc_unroll_actions() to read two
> extra bytes after an allocated area (not a big deal, but enough to
> displease the AddressSanitizer).
> 
> Signed-off-by: William Tu <u9012063 at gmail.com>
> Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
> Co-authored-by: Daniele Di Proietto <diproiettod at vmware.com>

Thanks William and Daniele, this is a good catch and further evidence
that we should apply the patch I posted earlier today:
        https://patchwork.ozlabs.org/patch/560273/

I applied this to master, branch-2.5, branch-2.4, and branch-2.3.



More information about the dev mailing list