[ovs-dev] [PATCH 3/5] ovsdb: perf counters

William Tu u9012063 at gmail.com
Wed Dec 23 18:35:13 UTC 2015


Hi Ben,

Sure, this is a memory leak reported by Valgrind. I will resubmit with more
details in commit message.

Regards,
William


On Tue, Dec 22, 2015 at 11:08 PM, Ben Pfaff <blp at ovn.org> wrote:

> On Thu, Dec 10, 2015 at 05:58:14PM -0800, William Tu wrote:
> > perf counters are used by ovsdb_txn_commit(), which can be called while
> > opening a database file.  This means we have to move the call to
> > perf_counters_init() before. Failed cases of Valgrind: 104, 106, 107
> >
> > Signed-off-by: William Tu <u9012063 at gmail.com>
> > Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
> > Co-authored-by: Daniele Di Proietto <diproiettod at vmware.com>
>
> Can you adjust the commit message to make it clear whether this is a bug
> or something else and if it's a bug what are the potential consequences?
> As is, it's hard to decide whether it needs to be backported to earlier
> versions.
>
> Thanks,
>
> Ben.
>



More information about the dev mailing list