[ovs-dev] [PATCH v2 3/3] physical: Improve treatment of localnet non-VLAN logical ports.

Russell Bryant russell at ovn.org
Thu Dec 31 03:27:53 UTC 2015


On Wed, Dec 23, 2015 at 4:23 PM, Ben Pfaff <blp at ovn.org> wrote:

> On Wed, Dec 23, 2015 at 03:41:04PM -0500, Russell Bryant wrote:
> > On 12/22/2015 04:17 PM, Ben Pfaff wrote:
> > > Until now, the flow table treated localnet logical ports that have a
> VLAN
> > > quite differently from those that don't.  The ones without a VLAN were
> > > essentially trunk ports: any packets that came in, that weren't picked
> off
> > > by a localnet port with a VLAN, were passed to the ones without a VLAN.
> > > This wasn't the intended behavior.
> > >
> > > This commit changes behavior to the intended behavior.  Now, localnet
> ports
> > > without a specific VLAN only receive packets without a VLAN header or
> those
> > > with VLAN ID 0 (with that header stripped off).
> > >
> > > Found by inspection.
> > >
> > > Signed-off-by: Ben Pfaff <blp at ovn.org>
> >
> > Acked-by: Russell Bryant <russell at ovn.org>
> >
> > I was able to test this using a new test case that I just posted to the
> > list.  It passes with v2 applied.
>
> Thanks.
>
> Is this for all three patches?
>

Sorry about that.  Sure, consider the ACK for all three patches.

The second one is trivial, so that's fine.  I didn't review the first one
quite as closely as the 3rd, but it seems sane and passes tests for me
locally.

-- 
Russell Bryant



More information about the dev mailing list