[ovs-dev] [PATCH] vlog: Fix "/dev/log" test

YAMAMOTO Takashi yamamoto at valinux.co.jp
Tue Feb 3 05:24:04 UTC 2015


> On Sun, Feb 1, 2015 at 9:18 PM, YAMAMOTO Takashi <yamamoto at valinux.co.jp> wrote:
>> commit 7905aae3fc1633c2c44c8fdb9e9d3a3d6e63439b
>> ("vlog: Don't fail syslog initialization in chroot.")
>> uses os.path.isfile("/dev/log"), which tests if the given path
>> is a regular file, to see if syslog can be usable.
>>
>> However, /dev/log is not a regular file for platforms I looked at.
>>     * On Ubuntu 14.04 and CentOS 6.5, /dev/log is a socket
>>     * On NetBSD-6, /dev/log is a symlink to a socket
>>
>> Replace the test with os.path.exists() so that it can work
>> as intended for these platforms.
>>
>> Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
> Sorry about that.
> Acked-by: Gurucharan Shetty <gshetty at nicira.com>

thank you.  applied.

YAMAMOTO Takashi



More information about the dev mailing list