[ovs-dev] [PATCH] ovs-dpctl: Do not report pmd info for 'dpif-netlink' datapath.

Ben Pfaff blp at nicira.com
Wed Feb 4 00:25:42 UTC 2015


On Tue, Feb 3, 2015 at 4:20 PM, Alex Wang <alexw at nicira.com> wrote:
>
>
> On Tue, Feb 3, 2015 at 2:55 PM, Ben Pfaff <blp at nicira.com> wrote:
>>
>> On Mon, Feb 02, 2015 at 03:03:32PM -0800, Alex Wang wrote:
>> > In 'ovs-dpctl dump-flows' output, we should only report the pmd
>> > related info for 'dpif-netdev' datapath.  However, current
>> > implementation also reports uninitialized pmd info for
>> > 'dpif-netlink' datapath, which is very confusing to users.
>> >
>> > This commit fixes it.
>> >
>> > Signed-off-by: Alex Wang <alexw at nicira.com>
>>
>> It seems like another alternative would be for this code to just skip
>> printing pmd ids when they're PMD_ID_NULL.  If we do that, can we avoid
>> adding a special case for netdev_dpif here?
>
>
> Yes, that should be the way to fix it... somehow I overlooked it... I'll
> resend it.

Thanks!



More information about the dev mailing list