[ovs-dev] [PATCH 1/2] mcast_snoop: make mcast_fport_bundle generic

[Flavio Leitner]

On Wednesday, February 04, 2015 10:54:59 AM Ben Pfaff wrote:
> On Wed, Feb 04, 2015 at 09:57:34AM -0800, Ben Pfaff wrote:
> > On Wed, Feb 04, 2015 at 11:07:05AM -0200, Flavio Leitner wrote:
> > > On Tuesday, February 03, 2015 04:07:24 PM Ben Pfaff wrote:
> > > > On Tue, Jan 20, 2015 at 01:20:56PM -0200, Flavio Leitner wrote:
> > > > > The struct mcast_fport_bundle will be used for ports
> > > > > forwarding Reports too, so make it generic.
> > > > > 
> > > > > Signed-off-by: Flavio Leitner <fbl at redhat.com>
> > > > 
> > > > I apologize that it has taken me a long time to review this patch.  As
> > > > usual, I have been busy; most recently, I was out the last five days to
> > > > an out-of-town corporate event where they kept us busy from 7am to 10pm
> > > > or later.  Hardly had time to breathe, let along review patches.
> > > 
> > > understandable, I just don't want to miss the 2.4 train.
> > >  
> > > > I need a little bit of help understanding this patch.  In particular,
> > > > the changes remove a 'vlan' parameter from a lot of function prototypes,
> > > > and I don't see anything replace it.  Was the VLAN somehow unused
> > > > previously?  I'd like to understand why it was needed before and somehow
> > > > not needed now.
> > > 
> > > Yes, it wasn't used at all so I took it out in the cleanup.
> > 
> > Oh, that makes sense.  I'll take another quick look then.
> 
> Both patches applied, thank you!

Thanks a lot!
fbl