[ovs-dev] [test-kmod improvements 6/6] test: remove openvswitch kernel module on test failure

[Joe Stringer]

I was hoping that some people with more understanding of how linux
modules work in general could give some context :-)

The difference between the error path and normal exit is that it's
more likely for the kernel to be in a bad state if it's the error
path.

Maybe the earlier patches to cleanup namespaces before removing kernel
module improves this enough. If we come across this problem, we can
investigate it then (or revert this patch).

Acked-by: Joe Stringer <joestringer at nicira.com>


On 6 February 2015 at 14:46, Andy Zhou <azhou at nicira.com> wrote:
> I don't have a solution to this. Any suggestions?
>
> The patch just add a module removal for the error path. The problem is
> also there for the normal test exit.
>
> On Fri, Feb 6, 2015 at 2:40 PM, Joe Stringer <joestringer at nicira.com> wrote:
>> On 5 February 2015 at 16:06, Andy Zhou <azhou at nicira.com> wrote:
>>> Improve test failure handling.
>>>
>>> Signed-off-by: Andy Zhou <azhou at nicira.com>
>>
>> What happens if "modprobe -r" hangs? (I occasionally notice this when
>> working with experimental kernel code, but I don't know what causes
>> it)