[ovs-dev] [PATCH] openvswitch: Add missing initialization in validate_and_copy_set_tun()

Thomas Graf tgraf at suug.ch
Wed Feb 11 15:57:38 UTC 2015


On 02/11/15 at 11:23am, Geert Uytterhoeven wrote:
> net/openvswitch/flow_netlink.c: In function ‘validate_and_copy_set_tun’:
> net/openvswitch/flow_netlink.c:1749: warning: ‘err’ may be used uninitialized in this function
> 
> If ipv4_tun_from_nlattr() returns a different positive value than
> OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS, err will be uninitialized, and
> validate_and_copy_set_tun() may return an undefined value instead of a
> zero success indicator. Initialize err to zero to fix this.
> 
> Fixes: 1dd144cf5b4b47e1 ("openvswitch: Support VXLAN Group Policy extension")
> Signed-off-by: Geert Uytterhoeven <geert at linux-m68k.org>

Acked-by: Thomas Graf <tgraf at suug.ch>



More information about the dev mailing list