[ovs-dev] [PATCH] tests: Enable running parallel unit tests for Windows.

Gurucharan Shetty shettyg at nicira.com
Thu Feb 12 02:55:16 UTC 2015


>
> Thanks for doing this.  I really like changes that make it easier or
> faster to run tests, because then developers are more likely to run
> them.
>
> I don't think that "patch" is currently required to build OVS.  I think
> that it's reasonable to require it--it is such a common utility--but I
> think that we should mention it in INSTALL.md.
>
> In the Makefile fragment, I would prefer to apply the patch before
> renaming the file.  That way, the new version of the testsuite appears
> atomically.
>
>> ++elif [ "$IS_WIN32" = "yes" ]; then
>
> The UNIX version of the parallel dispatcher has a few more tests:
>
>     if test $at_jobs -ne 1 &&
>          rm -f "$at_job_fifo" &&
>          test -n "$at_job_group" &&
>          ( mkfifo "$at_job_fifo" && trap 'exit 1' PIPE STOP TSTP ) 2>/dev/null
>
> Maybe it is worth checking at least that $at_jobs > 1?
All agreed. I will send a v2.
>
> Thanks,
>
> Ben.



More information about the dev mailing list