[ovs-dev] [PATCH/RFC v2 3/8] Support decoding of NMX selection method

[Ben Pfaff]

On Fri, Jan 30, 2015 at 11:41:51AM +0900, Simon Horman wrote:
> This is in preparation for supporting group mod and desc reply
> messages with an NMX selection method group experimenter property.
> 
> NMX selection method
> Signed-off-by: Simon Horman <simon.horman at netronome.com>
> 
> ---
> v2 Use list of struct field_array of TLVs rather than OF1.1 match
>    for fields field of NMX selection method property

It might be simpler to use an actual array for struct field_array.  I
guess that we can be sure there will be no more than MFF_N_IDS
elements?

In oxm_pull_field_arary(), DBG seems like a pretty low log level for
decoding errors.  I suspect that elsewhere in the same file we use
INFO or even WARN for similar messages, will you look around a bit?

I am not sure that nx_pull_match_entry() does what you want because it
validates each value as a value, whereas we want to validate it as a
mask.

I might have more comments later.