[ovs-dev] [PATCH] docs: update CONTRIBUTING.md

Ben Pfaff blp at nicira.com
Sun Feb 15 16:40:41 UTC 2015


On Tue, Feb 10, 2015 at 02:46:22PM +0000, Mark Kavanagh wrote:
> Patches that modify existing code can break expected behaviour.
> Flag this by testing the patch with 'make check' prior to submission.
> 
> Furthermore, it is not sufficient to only test patches that add files
> using 'make distcheck';the compile flags for this target could change
> the definition of some functions (ovs_assert, for example), altering
> the outcome of some unit tests. Rather, it is preferable to use a
> combination of 'make distcheck' with 'make check' to cover all bases.
> 
> Signed-off-by: Mark Kavanagh <mark.b.kavanagh at intel.com>

Thanks, applied.

I made the subject line more specific:
        CONTRIBUTING.md: Strengthen testing recommendataions.
(though now I see I introduced a spelling error, oh well).



More information about the dev mailing list