[ovs-dev] [PATCH] ovs-sandbox: Add an option to allow running ovs-vswitchd under gdb

[Andy Zhou]

Excellent idea. I like it!  Will do.  Thanks.

On Wed, Feb 18, 2015 at 10:08 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Wed, Feb 18, 2015 at 09:55:57PM -0800, Andy Zhou wrote:
>> On Wed, Feb 18, 2015 at 8:31 PM, Ben Pfaff <blp at nicira.com> wrote:
>> > On Wed, Feb 18, 2015 at 06:08:29PM -0800, Andy Zhou wrote:
>> >> It is some times useful to leverage the sandbox facility to experiment
>> >> and explore the internals of ovs-vswitchd.  Since GDB requires console
>> >> access for user inputs, this patch launch an xterm for GDB, The main
>> >> terminal continue to run the sub-shell as before. Exiting the sub-shell
>> >> will also kill the ovs-vswitchd under GDB (but not GDB itself currently)
>> >>
>> >> Signed-off-by: Andy Zhou <azhou at nicira.com>
>
> [...]
>
>> > Do you often run ovs-sandbox without "make"?  I haven't tried it that
>> > way.
>>
>> Should we remove the '-g' option?
>
> I think "-g" is fine.  I was just curious to find out whether you and I
> use the sandbox feature differently.
>
>> On a slightly different note,  I may end up move ovs-sandbox out of
>> tutorial directory, in case
>> we have another use for it, such as "ovsdb micro benchmark", but it is
>> premature to discuss at
>> this time.
>>
>> To directly answer your question, I don't use it directly currently.
>> I added the option since the
>> tutorial talked about run ovs-sandbox with installed OVS programs.  On
>> the other hand, the -g option
>> probably only make sense with the 'make' option.
>
> You could combine the two methods via:
>
>     diff --git a/tutorial/automake.mk b/tutorial/automake.mk
>     index 3d22d7a..5af0aac 100644
>     --- a/tutorial/automake.mk
>     +++ b/tutorial/automake.mk
>     @@ -9,4 +9,4 @@ EXTRA_DIST += \
>             tutorial/t-stage4
>
>      sandbox: all
>     -       cd $(srcdir)/tutorial && MAKE=$(MAKE) ./ovs-sandbox -b $(abs_builddir)
>     +       cd $(srcdir)/tutorial && MAKE=$(MAKE) ./ovs-sandbox -b $(abs_builddir) $(SANDBOXFLAGS)
>
> and then documenting "make sandbox SANDBOXFLAGS=-g" as the way to invoke
> the feature.  That's fairly clean, maybe that's the way to go?