[ovs-dev] [PATCH 6/8] ovsdb-doc: Factor out nroff formatting into a separate Python module.

Ben Pfaff blp at nicira.com
Thu Feb 19 19:13:42 UTC 2015


On Thu, Feb 19, 2015 at 11:07:18AM -0800, Gurucharan Shetty wrote:
> On Thu, Feb 19, 2015 at 9:23 AM, Ben Pfaff <blp at nicira.com> wrote:
> > On Thu, Feb 19, 2015 at 09:12:07AM -0800, Gurucharan Shetty wrote:
> >> On Thu, Feb 19, 2015 at 9:09 AM, Ben Pfaff <blp at nicira.com> wrote:
> >> > On Thu, Feb 19, 2015 at 11:00:56AM -0500, Russell Bryant wrote:
> >> >> On 02/19/2015 07:02 AM, Gurucharan Shetty wrote:
> >> >> > I don't understand nroff well enough to review patch 6 and patch 7. If
> >> >> > anyone else is up for it, please review.
> >> >>
> >> >> I don't either, but this one looks like just a code move.  It looks good
> >> >> to me.
> >> >
> >> > That's right, this is just code movement.
> >> It did look like you added an additional function while code
> >> refactoring. Maybe I did not look carefully.
> >
> > Oh, looking again, I added support for a <pic> element.  I didn't end
> > up using that later in the series, so I'm happy to drop it.
> 
> I am fine with the change. Thanks!

Thanks, applied!



More information about the dev mailing list