[ovs-dev] [PATCH 06/14 v2] datapath: Enable OVS GSO to be used up to 3.18 if necessary.

Thomas Graf tgraf at noironetworks.com
Fri Feb 20 10:38:23 UTC 2015


On 02/19/15 at 04:42pm, Pravin Shelar wrote:
> Did you considered getting rid of USE_KERNEL_TUNNEL_API and various
> kernel version check.  And just have one version check of 3.18 kernel
> to implement all tunnel backports?
> At this point we have most of tunnel code backported (few missing
> function like iptunnel_handle_offloads()). So we can define compat
> code for kernel older than 3.18, then only check we need is if
> ovs-compat code needs to handle GSO packets or not. We can merge 3.12
> and 3.18 kernel backport cases and handle the gso check in
> iptunnel_handle_offloads(). That code will be easier to read and
> debug.

USE_KERNEL_TUNNEL_API still has some RHEL6 backport build logic built
in. See the comment in ip_tunnels.h. I have no objection to removing
it but we should do a build test on RHEL6 and RHEL7 first. Flavio
might be able to help out.



More information about the dev mailing list