[ovs-dev] [PATCH v3 1/9] datapath: Enable OVS GSO to be used up to 3.18 if necessary.

Thomas Graf tgraf at noironetworks.com
Fri Feb 20 21:11:41 UTC 2015


This is an extremely nice cleanup overall.

On 02/20/15 at 10:50am, Jesse Gross wrote:
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,9,0)
> +#define SKB_GSO_GRE 0
> +#endif
> +
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,16,0)
> +#define SKB_GSO_GRE_CSUM 0
> +#endif

You might as well just check with #ifndef SKB_GSO_GRE to be more
liberal to future backports, e.g. I assume that RHEL7 will
eventually have SKB_GSO_GRE_CSUM and will declare itself as 3.10

I spent some time on this patch and couldn't spot anything
obviously wrong. I assume Pravin will have some comments to.
In the meantime, here is my:

Acked-by: Thomas Graf <tgraf at noironetworks.com>



More information about the dev mailing list