[ovs-dev] [PATCH 3/3] auto-attach: Add auto-attach support to bridge layer and command set

Ben Pfaff blp at nicira.com
Mon Feb 23 05:21:19 UTC 2015


On Sun, Feb 22, 2015 at 11:45:29AM -0800, Ben Pfaff wrote:
> On Fri, Feb 20, 2015 at 02:17:11PM -0500, drflynn at avaya.com wrote:
> > From: Dennis Flynn <drflynn at avaya.com>
> > 
> > This is the final commit in the series of commits that deliver initial support
> > for Auto-Attach. Specifically this commit delivers auto-attach support to the
> > OVS bridge layer as well as the new auto-attach commands. The OVSDB schema is
> > modified to define the new auto-attach entries. The man pages, unit tests, and
> > news and license notice files are also updated. A unit test is provided to
> > validate the construction of auto-attach packets.
> > 
> > Signed-off-by: Ludovic Beliveau <ludovic.beliveau at windriver.com>
> > Signed-off-by: Dennis Flynn <drflynn at avaya.com>
> 
> Hi Dennis, thanks for the new version.
> 
> I noticed some new warnings in this version.  These (from "sparse")
> probably mean that you should mark these variables "static":
> 
>     ../tests/test-aa.c:29:6: warning: symbol 'chassis_mac' was not declared. Should it be static?
>     ../tests/test-aa.c:30:9: warning: symbol 'eth_src' was not declared. Should it be static?
>     ../tests/test-aa.c:36:5: warning: symbol 'num_tests' was not declared. Should it be static?
> 
> Also these from GCC:
> 
>     ../utilities/ovs-vsctl.c: In function ‘cmd_get_aa_mapping’:
>     ../utilities/ovs-vsctl.c:2702:27: error: format ‘%lld’ expects argument of type ‘long long int’, but argument 3 has type ‘long int’ [-Werror=format=]
>                                (long int) br->br_cfg->auto_attach->value_mappings[i]
>                                ^
>     ../utilities/ovs-vsctl.c:2702:27: error: format ‘%lld’ expects argument of type ‘long long int’, but argument 4 has type ‘long int’ [-Werror=format=]

Never mind, I took care of this myself and posted a series that includes
these and some other refinements.  Dennis, will you look it over?

The series starts here:
        http://openvswitch.org/pipermail/dev/2015-February/051568.html

Thanks,

Ben.



More information about the dev mailing list