[ovs-dev] [PATCH] utilities/ovs-docker: Fix broken check_command_avail function

[Gurucharan Shetty]

On Fri, Feb 20, 2015 at 9:58 PM, Gurucharan Shetty <shettyg at nicira.com> wrote:
> On Fri, Feb 20, 2015 at 11:18 AM, Michael Smalley
> <michaeljsmalley at gmail.com> wrote:
>> Reported-by: Michael J. Smalley <michaeljsmalley at gmail.com>
>> Tested-by: Michael J. Smalley <michaeljsmalley at gmail.com>
>> Signed-off-by: Michael J. Smalley <michaeljsmalley at gmail.com>
> Thank you for the fix.
> As Ben mentioned in the other email, this patch potentially introduces
> 2 more bugs. Both 'which' and '!' (outside test) are considered
> non-portable by POSIX. There will be some shell where it will likely
> not work.
> If you don't mind, can you add the code that Ben provided and send
> another patch. Sorry for the trouble. If you prefer that I do it, let
> me know.
Michael mentioned off-list that he would prefer me taking caring of
this. So I sent a patch.