[ovs-dev] [PATCH 3/3] test-hash: Remove the check_word_hash() for hash_bytes128_cb.
Ben Pfaff
blp at nicira.com
Fri Feb 27 16:04:14 UTC 2015
On Thu, Feb 26, 2015 at 10:40:54AM -0800, Alex Wang wrote:
> The original test fails on big-endian system due to the hash function
> performing not as well when input is uint32_t. In reality, users should
> only use hash_bytes128() to hash words larger than 128 bits (e.g. struct
> flow). Besides, we do check the 1-bit set case for 16 128-bit words in
> following test case. Therefore, the cleanest way to fix the failure
> in big-endian system seems to be just removing the check_word_hash()
> test for hash_bytes128_cb.
>
> Signed-off-by: Alex Wang <alexw at nicira.com>
This seems like an OK compromise.
Acked-by: Ben Pfaff <blp at nicira.com>
More information about the dev
mailing list