[ovs-dev] [test-hash] test-hash: Test hash_bytes128() with single 128-bit word.

[Joe Stringer]

Looks good, minor comments inline.

On 27 February 2015 at 09:33, Alex Wang <alexw at nicira.com> wrote:
> This commit adds a new test for hash_bytes128() using single 128-bit
> word.  The test shows that there is no collision in all 17 consecutive
> bits checks, which indicates the hash function is good.
>
> Signed-off-by: Alex Wang <alexw at nicira.com>
> ---
>  tests/test-hash.c |  100 ++++++++++++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 88 insertions(+), 12 deletions(-)
>

It's 2015 now, so the copyright message at the top of the file can be updated.

>  static uint32_t
>  hash_words_cb(uint32_t input)
>  {
>      return hash_words(&input, 1, 0);
>  }
> -
>  static uint32_t
>  jhash_words_cb(uint32_t input)
>  {

Unnecessary whitespace change here.

Acked-by: Joe Stringer <joestringer at nicira.com>


Did the patch to remove the "exit(1)" from check_word_hash() get posted/applied?