[ovs-dev] [PATCH] configure: Omit -O2 from $CFLAGS when configuring with --enable-coverage.
Mijo Safradin
mijo at linux.vnet.ibm.com
Mon Jan 5 09:33:57 UTC 2015
> CFLAGS follows OVS_CFLAGS in the compiler command line, and should, so that
> the user can override any automatically determined compiler options. That
> means that the -O0 that the code here added to OVS_CFLAGS didn't really
> have any effect since CFLAGS by default includes "-O2". However, we do
> really want to disable optimizations (because the coverage reports are hard
> to interpret with optimizations), so this commit changes the configure
> script to edit out -O2 from CFLAGS, leaving any other default or
> user-specified options.
>
The "-O0" got lost, which is needed. Beside this, your patch is much
cleaner. Ack.
Thanks,
Mijo
More information about the dev
mailing list