[ovs-dev] [branch-2.3] ofproto-dpif-upcall: Make handler always call poll_block.

Alex Wang alexw at nicira.com
Tue Jan 6 18:49:26 UTC 2015


Thx for the review, applied to branch-2.3

Master has already done the similar thing,
and there is no need to backport to branch-2.1

On Tue, Jan 6, 2015 at 9:32 AM, Ben Pfaff <blp at nicira.com> wrote:

> On Mon, Dec 29, 2014 at 04:06:55PM -0800, Alex Wang wrote:
> > This commit makes handler threads always call poll_block() at
> > the end of each handling cycle.  If there are upcalls received
> > in the current cycle, the handler will register to wake up
> > immediately.  Otherwise, it will wait on both the netlink
> > socket and the exit latch.
> >
> > Calling poll_block() at every handling cycle makes sure that
> > coverage counter stats are always timely attributed, and that
> > the execution of ovsrcu-postponed events is not held by any
> > busy handler thread.
> >
> > Signed-off-by: Alex Wang <alexw at nicira.com>
>
> Acked-by: Ben Pfaff <blp at nicira.com>
>



More information about the dev mailing list