[ovs-dev] [PATCH 1/1] Bug setting vlan tci in compat function

Pravin Shelar pshelar at nicira.com
Mon Jan 12 18:45:36 UTC 2015


On Sat, Jan 10, 2015 at 3:00 PM, Thomas F Herbert
<thomasfherbert at entpnt.com> wrote:
> This patch fixes a bug when pushing vlans. It causes vlans to be transmitted with
> the TPID instead of the tci on the inner vlan.
>
> Signed-off-by: Thomas F Herbert <thomasfherbert at entpnt.com>

I pushed the fix to master.

Thanks.
> ---
>  datapath/linux/compat/include/linux/if_vlan.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/datapath/linux/compat/include/linux/if_vlan.h b/datapath/linux/compat/include/linux/if_vlan.h
> index 28c4dae..ab13a46 100644
> --- a/datapath/linux/compat/include/linux/if_vlan.h
> +++ b/datapath/linux/compat/include/linux/if_vlan.h
> @@ -129,7 +129,7 @@ static inline int rpl_vlan_insert_tag(struct sk_buff *skb, u16 vlan_tci)
>         veth->h_vlan_proto = htons(ETH_P_8021Q);
>
>         /* now, the TCI */
> -       veth->h_vlan_TCI = htons(ETH_P_8021Q);
> +       veth->h_vlan_TCI = htons(vlan_tci);
>
>         return 0;
>  }
> --
> 1.8.3.1
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list