[ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

Ben Pfaff blp at nicira.com
Tue Jan 13 23:45:52 UTC 2015


On Fri, Jan 02, 2015 at 05:41:58PM +0530, Saloni Jain wrote:
> Please find attached the updated patch for eviction feature, rebased with the latest ovs-master as on 02 Jan 2015.
> 
> This patch has correct code indentation. Kindly review it and provide your comments/inputs.

I can't get it to compile.  It uses a "table_vacancy" member but
doesn't appear to define it anywhere.  Maybe this requires some other
patch to be applied first.  If so, please send out the whole series,
ordered correctly.

Compiler errors:

    ../lib/ofp-print.c: In function 'ofp_print_table_mod':
    ../lib/ofp-print.c:1024:34: error: 'struct ofputil_table_mod' has no member named 'table_vacancy'
    ../lib/ofp-print.c:1024:32: error: too many arguments to function 'ofp_print_table_config'
    ../lib/ofp-print.c:985:1: note: declared here
    ../lib/ofp-print.c: In function 'ofp_print_table_desc':
    ../lib/ofp-print.c:1037:30: error: 'const struct ofputil_table_desc' has no member named 'table_vacancy'
    ../lib/ofp-print.c:1037:28: error: too many arguments to function 'ofp_print_table_config'
    ../lib/ofp-print.c:985:1: note: declared here


The only hits I see in the tree for table_vacancy are:

    lib/ofp-print.c:                               pm.table_vacancy);
    lib/ofp-print.c:                           td->table_vacancy);



More information about the dev mailing list