[ovs-dev] [PATCH net] openvswitch: packet messages need their own probe attribtue

Jesse Gross jesse at nicira.com
Wed Jan 14 20:40:44 UTC 2015


On Wed, Jan 14, 2015 at 5:56 AM, Thomas Graf <tgraf at suug.ch> wrote:
> User space is currently sending a OVS_FLOW_ATTR_PROBE for both flow
> and packet messages. This leads to an out-of-bounds access in
> ovs_packet_cmd_execute() because OVS_FLOW_ATTR_PROBE >
> OVS_PACKET_ATTR_MAX.
>
> Introduce a new OVS_PACKET_ATTR_PROBE with the same numeric value
> as OVS_FLOW_ATTR_PROBE to grow the range of accepted packet attributes
> while maintaining to be binary compatible with existing OVS binaries.
>
> Fixes: 05da589 ("openvswitch: Add support for OVS_FLOW_ATTR_PROBE.")
> Reported-by: Sander Eikelenboom <linux at eikelenboom.it>
> Tracked-down-by: Florian Westphal <fw at strlen.de>
> Signed-off-by: Thomas Graf <tgraf at suug.ch>

This is kind of a nasty bug, thanks for fixing it.

Reviewed-by: Jesse Gross <jesse at nicira.com>



More information about the dev mailing list