[ovs-dev] [PATCH] dpif: Use separate OVS_PACKET_ATTR_PROBE for packet messges

Jesse Gross jesse at nicira.com
Wed Jan 14 23:25:25 UTC 2015


On Wed, Jan 14, 2015 at 3:18 PM, Thomas Graf <tgraf at noironetworks.com> wrote:
> On 01/14/15 at 12:41pm, Jesse Gross wrote:
>> On Wed, Jan 14, 2015 at 9:21 AM, Thomas Graf <tgraf at noironetworks.com> wrote:
>> > User space is currently sending a OVS_FLOW_ATTR_PROBE for both flow
>> > and packet messages. This leads to an out-of-bounds access in
>> > ovs_packet_cmd_execute() because OVS_FLOW_ATTR_PROBE >
>> > OVS_PACKET_ATTR_MAX.
>> >
>> > Introduce a new OVS_PACKET_ATTR_PROBE with the same numeric value
>> > as OVS_FLOW_ATTR_PROBE to grow the range of accepted packet attributes
>> > while maintaining binary compatibility with existing OVS binaries.
>> >
>> > Fixes: 9233ce ("datapath: Add support for OVS_FLOW_ATTR_PROBE.")
>> > Reported-by: Sander Eikelenboom <linux at eikelenboom.it>
>> > Signed-off-by: Thomas Graf <tgraf at noironetworks.com>
>>
>> Acked-by: Jesse Gross <jesse at nicira.com>
>
> Thanks! Pushed to master.

I think probably branch-2.3 would be a good idea as well?



More information about the dev mailing list