[ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

[Rishi Bamba]

Hi Ben,

> On Fri, Jan 02, 2015 at 05:41:58PM +0530, Saloni Jain wrote:
> > Please find attached the updated patch for eviction feature,
> > rebased with the latest ovs-master as on 02 Jan 2015.
> > 
> > This patch has correct code indentation. Kindly review it and
> > provide your comments/inputs.
> 
> I can't get it to compile.  It uses a "table_vacancy" member but
> doesn't appear to define it anywhere.  Maybe this requires some other
> patch to be applied first.  If so, please send out the whole series,
> ordered correctly.

Our Team is working on this feature and I see the same issue as addressed.Though the same has been fixed
now and its getting successfully compiled on the master as on 16.01.2015.

This is the only patch for now and will be sending it Today i.e 16.01.2015

> Compiler errors:
> 
>     ../lib/ofp-print.c: In function 'ofp_print_table_mod':
>     ../lib/ofp-print.c:1024:34: error: 'struct ofputil_table_mod' has
>     no member named 'table_vacancy'
>     ../lib/ofp-print.c:1024:32: error: too many arguments to function
>     'ofp_print_table_config'
>     ../lib/ofp-print.c:985:1: note: declared here
>     ../lib/ofp-print.c: In function 'ofp_print_table_desc':
>     ../lib/ofp-print.c:1037:30: error: 'const struct
>     ofputil_table_desc' has no member named 'table_vacancy'
>     ../lib/ofp-print.c:1037:28: error: too many arguments to function
>     'ofp_print_table_config'
>     ../lib/ofp-print.c:985:1: note: declared here
> 
> 
> The only hits I see in the tree for table_vacancy are:
> 
>     lib/ofp-print.c:                               pm.table_vacancy);
>     lib/ofp-print.c:                           td->table_vacancy);
> 
> 

Hopefully these will not be there now. Request to kindly check with the revised patch.


Rishi

Thank You
Regards
Rishi Bamba
=====-----=====-----=====
Notice: The information contained in this e-mail
message and/or attachments to it may contain 
confidential or privileged information. If you are 
not the intended recipient, any dissemination, use, 
review, distribution, printing or copying of the 
information contained in this e-mail message 
and/or attachments to it are strictly prohibited. If 
you have received this communication in error, 
please notify us by reply e-mail or telephone and 
immediately and permanently delete the message 
and any attachments. Thank you