[ovs-dev] [PATCH 1/2] ofp-errors: Explain the whole "expected duplications" thing.

[Thomas Graf]

On 01/21/15 at 08:47pm, Ben Pfaff wrote:
> On Thu, Jan 22, 2015 at 12:21:20AM +0100, Thomas Graf wrote:
> > On 01/21/15 at 09:46am, Ben Pfaff wrote:
> > >  enum ofperr {
> > >  /* Expected duplications. */
> > >  
> > >      /* Expected: 0x0,3,5 in OF1.1 means both OFPBIC_BAD_EXPERIMENTER and
> > >       * OFPBIC_BAD_EXP_TYPE. */
> > >  
> > > +    /* Expected: 0x0,1,5 in OF1.0 means both OFPBRC_EPERM and
> > > +     * OFPBRC_IS_SLAVE. */
> > > +
> > > +    /* Expected: 0x0,1,5 in OF1.1 means both OFPBRC_EPERM and
> > > +     * OFPBRC_IS_SLAVE. */
> > > +
> > >  /* ## ------------------ ## */
> > >  /* ## OFPET_HELLO_FAILED ## */
> > >  /* ## ------------------ ## */
> > 
> > Did you intend to have this last change in patch 2?
> 
> Yes, oops.

Looks good otherwise

Acked-by: Thomas Graf <tgraf at noironetworks.com>