[ovs-dev] [PATCH 2/2] vlog: Logging option '--syslog-target' needs one argument.

Gurucharan Shetty shettyg at nicira.com
Mon Jan 26 17:00:19 UTC 2015


Without this commit, starting a daemon with just '--syslog-target'
causes a segmentation fault.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
---
 include/openvswitch/vlog.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/openvswitch/vlog.h b/include/openvswitch/vlog.h
index 0b69259..9cc7326 100644
--- a/include/openvswitch/vlog.h
+++ b/include/openvswitch/vlog.h
@@ -238,7 +238,7 @@ void vlog_rate_limit(const struct vlog_module *, enum vlog_level,
 #define VLOG_LONG_OPTIONS                                               \
         {"verbose",       optional_argument, NULL, 'v'},                \
         {"log-file",      optional_argument, NULL, OPT_LOG_FILE},       \
-        {"syslog-target", optional_argument, NULL, OPT_SYSLOG_TARGET},  \
+        {"syslog-target", required_argument, NULL, OPT_SYSLOG_TARGET},  \
         {"log-facility",  required_argument, NULL, OPT_LOG_FACILITY}
 
 #define VLOG_OPTION_HANDLERS                    \
-- 
1.7.9.5




More information about the dev mailing list