[ovs-dev] [PATCH 2/5 V6] Flow changes for 802.1ad

[Thomas F Herbert]

Ben,

On 1/28/15 11:31 AM, Ben Pfaff wrote:
> On Thu, Jan 08, 2015 at 04:29:12PM -0500, Thomas F Herbert wrote:
>> This patch adds support for 802.1ad by adding customer tci and tpid to the
>> flow structure.
>>
>> Signed-off-by: Thomas F Herbert <thomasfherbert at entpnt.com>
> This seems to be only half-general because it only allows for different
> TPIDs in one position.  It would seem more natural and more general to
> me to support a flexible TPID in each position.

My thinking was that I was trying to add only what was absolutely necessary to the flow by inferring the inner tag value by slavishly following 802.1ad that specifies 0x88a8 for the outer and 0x8100 for the inner TPID.

However, your point is well taken. Also, adding the inner tpid does simplify the code so I will change it in V7.

Thanks,

--Tom

-- 
Thomas F. Herbert
Network Implementation Engineer
Entry Point LLC