[ovs-dev] [PATCH 3/5 V6] Vlan parsing: 802.1AD and encapsulated Vlan

[Thomas F Herbert]

On 1/28/15 11:41 AM, Ben Pfaff wrote:
> On Thu, Jan 08, 2015 at 04:29:13PM -0500, Thomas F Herbert wrote:
>> This patch adds support for 802.1AD by adding parsing of 802.1AD double
>> stacked vlans.
>>
>> Signed-off-by: Thomas F Herbert <thomasfherbert at entpnt.com>
> It looks like odp_flow_key_from_flow__() only ever pushes one VLAN
> header into the ODP flow key (or maybe I'm misinterpreting it?).
Your reading of the code is correct. It only pushes one VLAN header 
because in my reading of OF, the argument to the push consists only of 
one TPID and one TCI and therefore only pushes one outer tag. Am I 
missing something?
>
> It looks like parse_8021ad_onward() duplicates a lot of code from
> parse_8021q_onward().  I think it would be better to try to keep as much
> common code as possible.
Yes, there is unnecessary code duplication and has already been fixed 
for V7.
>
> Please be careful about CodingStyle.  In particular I see a number of
> code blocks that lack {}.
OK

Thanks for your comments,

--Tom

-- 
Thomas F. Herbert
Network Implementation Engineer
Entry Point LLC