[ovs-dev] [PATCH] vlog: Don't fail syslog initialization in chroot.

Gurucharan Shetty shettyg at nicira.com
Thu Jan 29 19:02:29 UTC 2015


On Thu, Jan 29, 2015 at 6:58 AM, Thomas Graf <tgraf at noironetworks.com> wrote:
> On 01/28/15 at 01:19pm, Gurucharan Shetty wrote:
>> When OVS unit tests are run inside chroot environment,
>> there is no syslog infrastructure available. In a
>> situation like that, don't fail or log additional messages.
>>
>> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
>
> The commit message "don't [...] log additional messages" confused me at
> first, until I realized that the Vlog class attempts to use all of
>
>         {"console": "info", "file": "info", "syslog": "info"}
>
> for logging and this change causes syslog to be skipped if /dev/log
> is not available so messages would still be logged to the console.
You are right. I provided a little more detail to the commit message
and pushed this.
>
> Acked-by: Thomas Graf <tgraf at noironetworks.com>



More information about the dev mailing list