[ovs-dev] [PATCH 01/11] datapath: Account for "rename vlan_tx_* helpers since "tx" is misleading there"

Thomas Graf tgraf at noironetworks.com
Fri Jan 30 10:34:32 UTC 2015


On 01/29/15 at 07:44pm, Pravin Shelar wrote:
> > +#ifndef HAVE_SKB_VLAN_TAG_PRESENT
> > +#define skb_vlan_tag_present(skb) vlan_tx_tag_present(skb)
> > +#define skb_vlan_tag_get(skb) vlan_tx_tag_get(skb)
> > +#endif
> > +
> 
> 
> No need to search skb_vlan_tag_present(), since it is macro we can use
> #undef instead. We should be careful while adding OVS_GREP_IFELSE to
> configure script, since it does increase build time.

Agreed. Changed to simple #ifndef.



More information about the dev mailing list