[ovs-dev] [PATCH] ovs-vsctl.at: Fix intermittent failure.

Alex Wang alexw at nicira.com
Fri Jan 30 21:04:51 UTC 2015


Thx for spotting it, i did not copy the entire example and missed the
'test',

This failure is very hard to reproduce on my setup, so it passed 30 runs,

I'll fix it and repost,

Thanks,
Alex Wang,

On Fri, Jan 30, 2015 at 12:38 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Fri, Jan 30, 2015 at 10:51:49AM -0800, Alex Wang wrote:
> > This commit fixes the intermittent test failure caused by the
> > race between the test thread and logging thread.
> >
> > Signed-off-by: Alex Wang <alexw at nicira.com>
>
> OVS_WAIT_WHILE doesn't have an implied invocation of "test", so I'm
> surprised that this helps, since it expands to something like "if 0
> -ge 1", which isn't sensible Bourne shell:
> > +OVS_WAIT_WHILE([`grep -- "|WARN|" ovs-vswitchd.log | wc -l` -ge 1])
>



More information about the dev mailing list