[ovs-dev] [PATCH] datapath-windows: Failed initialization for datapath tunnel ports

[Sorin Vinturis]

Eitan,

This code was changed by the STT patch. If the created tunnel has specified the tunnel destination port, then the issue does not occur. But if the created tunnel does not have a specified tunnel port, then the default port is not set and the tunnel destination port will be zero, thus the problem.

Thanks,
Sorin

-----Original Message-----
From: Eitan Eliahu [mailto:eliahue at vmware.com] 
Sent: Wednesday, 1 July, 2015 18:21
To: Sorin Vinturis; dev at openvswitch.org
Subject: RE: [PATCH] datapath-windows: Failed initialization for datapath tunnel ports

Hi Sorin,
Can you explain which change broke this code.
I recall validating connectivity on STT and I believe Nithin validated on STT and on VXLAN channel as well.
Thanks,
Eitan

-----Original Message-----
From: dev [mailto:dev-bounces at openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Wednesday, July 01, 2015 12:52 AM
To: dev at openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: Failed initialization for datapath tunnel ports

Tunnel ports are not initialized with the corresponding default port.
The newly allocated vport is not yet initialized and the ovsType member does not reflect the correct tunnel port type, thus the transport port destination won't be correctly initialized.

Signed-off-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
Reported-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
Reported-at: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs-2Dissues_issues_88&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=pfesL1KVpNw4qmTq5MZIQqau5e5kp7SsBE2NKZPDZ-c&s=SNm8Qtz_cxNIYVDKYh4l_LI6uE5u2TiHBhM3JAF_WA4&e=
---
 datapath-windows/ovsext/Vport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c index 9139545..bff3ff6 100644
--- a/datapath-windows/ovsext/Vport.c
+++ b/datapath-windows/ovsext/Vport.c
@@ -2160,7 +2160,7 @@ OvsNewVportCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx,
         if (OvsIsTunnelVportType(portType)) {
             UINT16 transportPortDest = 0;
 
-            switch (vport->ovsType) {
+            switch (portType) {
             case OVS_VPORT_TYPE_VXLAN:
                 transportPortDest = VXLAN_UDP_PORT;
                 break;
--
1.9.0.msysgit.0
_______________________________________________
dev mailing list
dev at openvswitch.org
https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=pfesL1KVpNw4qmTq5MZIQqau5e5kp7SsBE2NKZPDZ-c&s=yyR0IBVadQHVJleSVrBVbjjppum2LP-iZVNNO2aYa_U&e=