[ovs-dev] [PATCH] datapath-windows: Solved BSOD when handling flows

Sorin Vinturis svinturis at cloudbasesolutions.com
Wed Jul 1 17:28:07 UTC 2015


OvsPrepareFlow() returns an error only when the new flow allocation
fails. In this case HandleFlowPut() should return error without trying
to free the flow, thus avoiding the BSOD.

Signed-off-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
Reported-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
Reported-at: https://github.com/openvswitch/ovs-issues/issues/91
---
This patch should be applied both on master and branch 2.4.
---
 datapath-windows/ovsext/Flow.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index 6fa10a3..b93f475 100644
--- a/datapath-windows/ovsext/Flow.c
+++ b/datapath-windows/ovsext/Flow.c
@@ -2163,7 +2163,6 @@ HandleFlowPut(OvsFlowPut *put,
 
         status = OvsPrepareFlow(&KernelFlow, put, hash);
         if (status != STATUS_SUCCESS) {
-            FreeFlow(KernelFlow);
             return STATUS_UNSUCCESSFUL;
         }
 
-- 
1.9.0.msysgit.0



More information about the dev mailing list