[ovs-dev] [PATCH 2/2] Undefined symbol make_unix_socket

Eitan Eliahu eliahue at vmware.com
Wed Jul 1 18:58:59 UTC 2015


Acked-by: Eitan Eliahu <eliahue at vmware.com>
Thanks,
Eitan

-----Original Message-----
From: Alin Serdean [mailto:aserdean at cloudbasesolutions.com] 
Sent: Wednesday, July 01, 2015 11:49 AM
To: Eitan Eliahu; dev at openvswitch.org
Subject: RE: [PATCH 2/2] Undefined symbol make_unix_socket

Hi Eitan,



It would be a nice idea for a future feature. I think this issue is related to that: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs-2Dissues_issues_74&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=mnhiuiHZ3Anzhv-e-D4lRdTb1bqvx_i7JKZ6mjDQ7Hg&s=U_DHjCEmSBPo2PVDGEy_8cew0YmY3QVld4tLY1Hrqg4&e= .



Alin.



-----Mesaj original-----

De la: Eitan Eliahu [mailto:eliahue at vmware.com] 

Trimis: Wednesday, July 1, 2015 6:03 PM

Către: Alin Serdean; dev at openvswitch.org

Subiect: RE: [PATCH 2/2] Undefined symbol make_unix_socket





Hi Alin,

Should we implement OVS system logging for Windows through the use of "Application Event Logging"?

Thanks,

Eitan



-----Original Message-----

From: dev [mailto:dev-bounces at openvswitch.org] On Behalf Of Alin Serdean

Sent: Tuesday, June 30, 2015 9:28 AM

To: dev at openvswitch.org

Subject: [ovs-dev] [PATCH 2/2] Undefined symbol make_unix_socket



syslog_direct_create defined in (lib/syslog-direct.c) uses make_unix_socket which is currently undefined on the windows build.



We either can remove the new file from the chain but this patch proposes to define a wrapper to make_unix_socket in which we return EINVAL.



This will avoid this kind of problems in the future.



Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>

---

 lib/socket-util.h | 7 +++++++

 1 file changed, 7 insertions(+)



diff --git a/lib/socket-util.h b/lib/socket-util.h index 1178fb8..a0a5c36 100644

--- a/lib/socket-util.h

+++ b/lib/socket-util.h

@@ -95,6 +95,13 @@ int af_inet_ifreq_ioctl(const char *name, struct ifreq *,  #endif

 

 #ifdef _WIN32

+static inline int make_unix_socket(int style, bool nonblock,

+                                   const char *bind_path,

+                                   const char *connect_path) {

+    return EINVAL;

+}

+

 /* Windows defines the 'optval' argument as char * instead of void *. */  #define setsockopt(sock, level, optname, optval, optlen) \

     rpl_setsockopt(sock, level, optname, optval, optlen)

--

1.9.5.msysgit.0

_______________________________________________

dev mailing list

dev at openvswitch.org

https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=y_igwxCxxtgun7X4BmzxDG2ek0C_h9frh1L9ukvLkuc&s=zcKFCr4PuGr2y2JPn60J1jdtIFKCtjqoPxtLm4kw0gY&e= 



More information about the dev mailing list