[ovs-dev] [PATCH v2] Undefined symbol make_unix_socket

Ben Pfaff blp at nicira.com
Wed Jul 1 20:20:45 UTC 2015


On Wed, Jul 01, 2015 at 07:01:44PM +0000, Alin Serdean wrote:
> syslog_direct_create defined in (lib/syslog-direct.c) uses make_unix_socket
> which is currently undefined on the windows build.
> 
> We either can remove the new file from the chain but this patch proposes
> to define a wrapper to make_unix_socket in which we return EINVAL.
> 
> This will avoid this kind of problems in the future.
> 
> Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
> Acked-by: Eitan Eliahu <eliahue at vmware.com>

It might be better to just not build syslog-direct at all on Windows,
since it's never going to do anything useful there (as far as I know).

Ansis, what do you think?



More information about the dev mailing list