[ovs-dev] [PATCH] ovn: Take advantage of OVSDB garbage collection in OVN_Northbound schema.

[Russell Bryant]

On 07/02/2015 01:47 PM, Ben Pfaff wrote:
> On Thu, Jul 02, 2015 at 11:48:11AM -0400, Russell Bryant wrote:
>> On 07/01/2015 03:46 PM, Russell Bryant wrote:
>>> On 07/01/2015 03:40 PM, Aaron Rosen wrote:
>>>> Fwiw the neutron side is ready to merge as well:
>>>>
>>>> https://review.openstack.org/#/c/196132/
>>>>
>>>> we also were able to test your patch in the gate
>>>> https://review.openstack.org/#/c/196131/4 with this patchset on top and it
>>>> fixes the race we were seeing before.
>>>
>>> Awesome, thanks everyone!
>>>
>>> The only thing I noticed in the OVN patch was that tabs were used as
>>> indentation in ovn-nb.ovsschema where it was all spaces before.  Otherwise:
>>>
>>> Acked-by: Russell Bryant <rbryant at redhat.com>
>>>
>>
>> I noticed one change in behavior.  With this patch, an extra entry is
>> getting added to Pipeline that wasn't there before for table 1, priority
>> 0.  This entry is supposed to handle output to ports with a mac set to
>> 'unknown'.  If there are no such ports, it now puts an entry in with no
>> actions instead of not being there at all like before.
>>
>> It just results in an explicit drop flow getting added:
>>
>> cookie=0x0, duration=1.530s, table=17, n_packets=0, n_bytes=0,
>> priority=0,metadata=0x1 actions=drop
>>
>> but I don't think the Pipeline docs specify that "drop" is the default
>> action if nothing is specified, so it'd be good to either add that to
>> the docs, remove this Pipeline entry, or update the entry to say "drop"
>> explicitly.  I don't really have a strong opinion on which one.
> 
> I think we should remove the entry.  There was a bug here anyway, I'll
> fix that.
> 
> The Pipeline table docs do say that it's a drop:
> 
> 	An
> 	empty set of actions (or one that contains just white space or
> 	comments), or a set of actions that consists of just
> 	<code>drop;</code>, causes the matched packets to be dropped.
> 

Oops, I missed that.  Sorry!

-- 
Russell Bryant