[ovs-dev] [PATCH 1/2] datapaht/README: fixed some minor typos

Luis E Pena lpena at vmware.com
Thu Jul 2 19:01:03 UTC 2015


So, what should I do? Should I redo the patch without the subject typo and without the article and without the whitespace?

> On Jul 2, 2015, at 11:33, Justin Pettit <jpettit at nicira.com> wrote:
> 
> 
>> On Jul 2, 2015, at 11:13 AM, Ben Pfaff <blp at nicira.com> wrote:
>> 
>> On Thu, Jul 02, 2015 at 11:12:00AM -0700, Ethan Jackson wrote:
>>> The patch introduces some trailing whitespace.
>>> 
>>>> -  - If userspace's notion of the flow key for the packet matches the
>>>> +  - If the userspace's notion of the flow key for the packet matches the
>>> 
>>> I don't agree with this change.  It's pretty common to talk about
>>> userspace without a "the" as the README originally did.
>>> 
>>> Otherwise looks good.  If you resend it with those changes I'll merge it.
>> 
>> Also, there is a typo in the subject.
> 
> I caught the whitespace and typo in subject.  I'll make the userspace article change before I push the change.
> 
> --Justin
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=vLBOU1QC09fNCgzE9c0HcQ&m=WI_ZxCjIqd6b-e2Jt6xOYOb-bToU9xxO70cx_d7xoeA&s=wPkTR6KhVvXgReKewaDFFe3u9zBl8nur6yOVdOWeaqA&e= 




More information about the dev mailing list