[ovs-dev] [PATCH 1/6] ofproto: Hold ofproto_mutex when enabling or disabling eviction.

[Ben Pfaff]

On Thu, Jul 02, 2015 at 05:40:32AM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>

Thanks!  I will apply this to master and backport as necessary soon.

> I would have expected clang to flag different annotations as a
> warning… Did you look if we have similar situations with other
> functions? Would it be possible to automate such a check somehow?

Clang only reports warnings based on annotations, at the point where the
warning would be raised, if the annotations were present on the most
recently seen prototype for the function.  This means that, for best
coverage, both an initial prototype and a later function definition must
be annotated.  I personally regard this as a Clang bug, but I don't know
of a way to make it change behavior or even to report a warning if the
annotations are different or missing at one site or another.