[ovs-dev] [PATCH 1/2] ofproto: Add struct ofproto_flow_mod.

Ben Pfaff blp at nicira.com
Mon Jul 6 15:56:24 UTC 2015


On Wed, Jul 01, 2015 at 12:45:04PM -0700, Jarno Rajahalme wrote:
> It is cleaner to not use ofp_bundle_entry for non-bundle flow mods.
> To address this, the new struct ofproto_flow_mod combines an
> ofputil_flow_mod and the necessary execution context for executing the
> start, revert, and finish phases of the flow mod, which all were
> previously members of struct ofp_bundle_entry.
> 
> This also simplifies many of the function prototypes introduced with
> the OF 1.4 bundles code.  However, in case of learn action execution
> this approach requires a new copy of the ofputil_flow_mod.  This could
> be avoided by making struct ofproto_flow_mod more complex, but it
> seems not worth the complication.
> 
> As part of carving out the execution context from ofp_bundle_entry to
> ofproto_flow_mod, the 'version' member is now also in
> ofproto_flow_mod, as it makes sense for flow mods, but not for port
> mods.  Now that the functions operate on the version also get the full
> execution context, they use 'version' instead of
> 'ofproto->tables_version'. This allows ofproto->tables_version to be
> changed only when a new version is committed.
> 
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

Builds cleanly, passes the tests.  It seems like mostly
search-and-replace so I didn't read it carefully.

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list