[ovs-dev] [RFC PATCH v2 1/7] tests: Check for core files before exiting.

Jarno Rajahalme jrajahalme at nicira.com
Fri Jul 10 17:35:19 UTC 2015


I've seen core files appear and then be automatically removed as the
test case was successful.  Such success is highly doubtful, so fail
the test cases if any core files exist at the end of the test.

Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
---
 tests/ofproto-macros.at |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at
index 74b02b7..124e581 100644
--- a/tests/ofproto-macros.at
+++ b/tests/ofproto-macros.at
@@ -116,6 +116,9 @@ m4_define([OVS_VSWITCHD_START],
 ])
 
 m4_divert_push([PREPARE_TESTS])
+check_cores () {
+    find . -name core -print
+}
 check_logs () {
     sed -n "$1
 /timeval.*Unreasonably long [[0-9]]*ms poll interval/d
@@ -138,7 +141,8 @@ m4_divert_pop([PREPARE_TESTS])
 #
 #   OVS_VSWITCHD_STOP(["/expected error/d"])
 m4_define([OVS_VSWITCHD_STOP],
-  [AT_CHECK([check_logs $1])
+  [AT_CHECK([check_cores])
+   AT_CHECK([check_logs $1])
    AT_CHECK([ovs-appctl -t ovs-vswitchd exit])
    AT_CHECK([ovs-appctl -t ovsdb-server exit])])
 
-- 
1.7.10.4




More information about the dev mailing list