[ovs-dev] [RFC net-next 11/22] dst: Metadata destinations

Julian Anastasov ja at ssi.bg
Fri Jul 10 18:57:31 UTC 2015


	Hello,

On Fri, 10 Jul 2015, Thomas Graf wrote:

> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -1691,6 +1691,8 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
>  	   by fib_lookup.
>  	 */
>  
> +	skb_dst_drop(skb);
> +

	This is not very safe. There are places that
call ip_route_input() for temporary lookups and they
do not set NULL. For example, icmp_route_lookup(),
may be there are other such places...

	OTOH, ip_options_rcv_srr() looks correct to use
skb_dst_set(skb, NULL), may be such call should be
added if it is missing...

>  	if (ipv4_is_multicast(saddr) || ipv4_is_lbcast(saddr))
>  		goto martian_source;

Regards

--
Julian Anastasov <ja at ssi.bg>



More information about the dev mailing list