[ovs-dev] [PATCH 2/2] tunneling: Allow matching and setting tunnel 'OAM' flag.

[Jesse Gross]

On Wed, Jul 15, 2015 at 12:37 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Jul 13, 2015 at 02:53:57PM -0700, Jesse Gross wrote:
>> Several encapsulation formats have the concept of an 'OAM' bit
>> which typically is used with networking tracing tools to
>> distinguish test packets from real traffic. OVS already internally
>> has support for this, however, it doesn't do anything with it
>> and it also isn't exposed for controllers to use. This enables
>> support through OpenFlow.
>>
>> There are several other tunnel flags which are consumed internally
>> by OVS. It's not clear that it makes sense to use them externally
>> so this does not expose those flags - although it should be easy
>> to do so if necessary in the future.
>>
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
>
> Is part of the mf_is_all_wild() change a bug fix that we should
> backport?  At first glance it seems so.

The existing code is definitely conceptually wrong. However, I don't
believe that it can ever result in a triggerable bug. None of these
fields were publicly accessible before now so mf_is_all_wild() should
never be called for those fields.