[ovs-dev] [v2 2/2] ovsdb: Add per transaction commit instruction counter

[Andy Zhou]

When dropping perf-counter.c, I missed that It also contained a fix
that is necessary for the remaining patches for pass unit tests.

I will add it back to the patch set and post v3.  Sorry about this.

On Tue, Jul 14, 2015 at 5:06 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Tue, Jul 14, 2015 at 03:57:15PM -0700, Ben Pfaff wrote:
>> On Wed, Jul 08, 2015 at 02:17:57PM -0700, Andy Zhou wrote:
>> > Measure user space only instruction counters for commit each
>> > transaction. This measurement is mainly useful for
>> > tuning OVSDB internal implementation, such as how OVSDB scales over
>> > number of client connections.
>> >
>> > A simple usage example:
>> >
>> > ovs-appctl -t ovsdb-server ovsdb-server/perf-counters-clear
>> > ovs-vsctl add-port br0 p3
>> > ovs-appctl -t ovsdb-server ovsdb-server/perf-counters-show
>> > ovsdb_txn_commit            2      906922 453461.0
>> >
>> > The commands above show that the 'add-port br p3' command caused ovsdb
>> > to execute 2 transactions. Each transaction takes 453461 instructions,
>> > total 906922 instructions. The number will vary based on number of
>> > ovsdb clients connected.
>> >
>> > Signed-off-by: Andy Zhou <azhou at nicira.com>
>> > Acked-by: Ben Pfaff <blp at nicira.com>
>>
>> Acked-by: Ben Pfaff <blp at nicira.com>
>
> Actually I have to take this back, because this commit causes tons of
> test failures for me:
>
>        Subject: [openvswitch 2.4.90] testsuite: 103 104 105 106 107 108 118 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1383 1384 1390 1394 1396 1450 1451 1452 1454 1455 1457 1458 1468 1469 1470 1471 1472 1473 1474 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1580 1581 1582 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 failed
>
> The tests all seem to fail because of segfaults in ovsdb-server.