[ovs-dev] [PATCH] ovn - Add 'name' field to Logical Router port

Gal Sagie gal.sagie at gmail.com
Thu Jul 16 19:11:28 UTC 2015


I will re-send with gal.sagie at gmail.com

On Thu, Jul 16, 2015 at 7:07 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Thu, Jul 16, 2015 at 08:49:44AM -0400, Russell Bryant wrote:
> > On 07/16/2015 07:51 AM, Gal Sagie wrote:
> > > Similar to logical port, its convinent to use a 'name'
> > > field for the logical router port
> > >
> > > Signed-off-by: Gal Sagie <gal.sagie at huawei.com>
> >
> > The patch seems fine to me, so:
> >
> > Acked-by: Russell Bryant <rbryant at redhat.com>
> >
> > However, your Signed-off-by email doesn't match what'll be in the Author
> > field (@gmail.com).  Also, your gmail address is what's used for your
> > other patches and acks.  I'm not sure how much this all actually
> > matters, but it at least seems odd to mix them within the same patch.
>
> I think the author and sign-off should match.  Gal, can you update one
> or the other and re-send?
>
> Thanks,
>
> Ben.
>



-- 
Best Regards ,

The G.



More information about the dev mailing list