[ovs-dev] [PATCH v3 1/3] tests: Check for core files before exiting.

[Jarno Rajahalme]

> On Jul 16, 2015, at 4:33 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> On Thu, Jul 16, 2015 at 03:15:52PM -0700, Jarno Rajahalme wrote:
>> I've seen core files appear and then be automatically removed as the
>> test case was successful.  Such success is highly doubtful, so fail
>> the test cases if any core files exist at the end of the test.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> I proposed a similar patch in May 2014:
>        http://openvswitch.org/pipermail/dev/2014-May/040497.html
> but you didn't like it:
>        http://openvswitch.org/pipermail/dev/2014-May/040857.html

My comment at the time was that I did not see the result of the line

echo "$core: core dumped during test"
anywhere, but now I see that this is simply due to the fact that the test case failed on an earlier AT_CHECK and never got to checking the cores.

So I see that this patch has the same limitation. Do you have any idea how to check and report for core files regardless of the success or failure of the test case? I think this would be important as I’ve seen cores in both cases. In success case we currently lose the fact that there even was a core dump, and this likely happens also in the failure case if we blindly run a —recheck and by chance succeed that time.

Right now I habitually run “find . -name core -print” from a shell after each “make check” that has any failures before a —recheck. I’d like to automate this somehow! And this doesn’t even catch the cores of successful test cases. The only reason I know they exist was due to running the find command multiple times while “make check” was running, and I saw some core files that had disappeared in later find runs.

  Jarno