[ovs-dev] [PATCH] db-ctl-base: Add "static" to definition of ctl_exit().

Ben Pfaff blp at nicira.com
Mon Jul 20 18:25:32 UTC 2015


Thanks, applied to master.

On Mon, Jul 20, 2015 at 11:24:31AM -0700, Alex Wang wrote:
> Acked-by: Alex Wang <alexw at nicira.com>
> 
> On Mon, Jul 20, 2015 at 11:20 AM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > The prototype said "static" but the definition did not.
> >
> > Reported by sparse.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> >  lib/db-ctl-base.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c
> > index e3c0373..09efd8d 100644
> > --- a/lib/db-ctl-base.c
> > +++ b/lib/db-ctl-base.c
> > @@ -1953,7 +1953,7 @@ ctl_fatal(const char *format, ...)
> >   * Freeing the transaction and the IDL is not strictly necessary, but it
> > makes
> >   * for a clean memory leak report from valgrind in the normal case.  That
> > makes
> >   * it easier to notice real memory leaks. */
> > -void
> > +static void
> >  ctl_exit(int status)
> >  {
> >      if (ctl_exit_func) {
> > --
> > 2.1.3
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >



More information about the dev mailing list